Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 514113003: [ServiceWorker] Create a new Blob when body.asBody() is called if the size of body is not set. (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
michaeln
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Create a new Blob when body.asBody() is called if the size of body is not set. This patch fixes the wrong size of blob which can be get by calling FetchEvent.request.body.asBody() of the fetch event which body includes a file item. This change depends on https://codereview.chromium.org/517543002. BUG=402387 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181077

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -75 lines) Patch
M LayoutTests/http/tests/local/serviceworker/fetch-request-body-file.html View 1 chunk +79 lines, -61 lines 0 comments Download
M LayoutTests/http/tests/local/serviceworker/resources/fetch-request-body-file-worker.js View 1 chunk +21 lines, -8 lines 0 comments Download
M Source/modules/serviceworkers/FetchBodyStream.cpp View 2 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
horo
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-28 11:40:33 UTC) #1
horo
Patchset #1 (id:20001) has been deleted
6 years, 3 months ago (2014-08-28 11:57:39 UTC) #2
horo
horo@chromium.org changed reviewers: + michaeln@chromium.org
6 years, 3 months ago (2014-08-28 12:02:28 UTC) #3
horo
michaeln@ Could you please review?
6 years, 3 months ago (2014-08-28 12:02:28 UTC) #4
michaeln
lgtm
6 years, 3 months ago (2014-08-28 22:53:54 UTC) #5
horo
The CQ bit was checked by horo@chromium.org
6 years, 3 months ago (2014-08-29 04:23:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/514113003/40001
6 years, 3 months ago (2014-08-29 04:24:23 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 3 months ago (2014-08-29 05:39:46 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 06:26:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as 181077

Powered by Google App Engine
This is Rietveld 408576698