content/child/service_worker/web_service_worker_impl.cc - Issue 517493002: ServiceWorker: Update the install sequence as per the latest spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_impl.cc

Issue 517493002: ServiceWorker: Update the install sequence as per the latest spec (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment fix (+rebase) Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_message_filter.cc ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_impl.cc

diff --git a/content/child/service_worker/web_service_worker_impl.cc b/content/child/service_worker/web_service_worker_impl.cc

index e76822362ed322a482c0137ae00faac59e38649a..dcd69ca8a902799d1dba64dea0398819785c5a6d 100644

--- a/content/child/service_worker/web_service_worker_impl.cc

+++ b/content/child/service_worker/web_service_worker_impl.cc

@@ -43,8 +43,7 @@ WebServiceWorkerImpl::~WebServiceWorkerImpl() {

void WebServiceWorkerImpl::OnStateChanged(

blink::WebServiceWorkerState new_state) {

- DCHECK(proxy_);

- if (proxy_->isReady())

+ if (proxy_ && proxy_->isReady())

CommitState(new_state);

else

queued_states_.push_back(new_state);