Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: content/child/service_worker/service_worker_message_filter.cc

Issue 517493002: ServiceWorker: Update the install sequence as per the latest spec (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix (+rebase) Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_message_filter.cc
diff --git a/content/child/service_worker/service_worker_message_filter.cc b/content/child/service_worker/service_worker_message_filter.cc
index 15ac1d6ed4e702d12e93b7636dfd55dd97a65b4f..72cf320084a61f53dc3d060b001f7dc08d7f3feb 100644
--- a/content/child/service_worker/service_worker_message_filter.cc
+++ b/content/child/service_worker/service_worker_message_filter.cc
@@ -81,7 +81,14 @@ void ServiceWorkerMessageFilter::OnStaleMessageReceived(
void ServiceWorkerMessageFilter::OnStaleRegistered(
int thread_id,
int request_id,
- const ServiceWorkerRegistrationObjectInfo& info) {
+ const ServiceWorkerRegistrationObjectInfo& info,
+ const ServiceWorkerVersionAttributes& attrs) {
+ SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(),
+ attrs.installing.handle_id);
+ SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(),
+ attrs.waiting.handle_id);
+ SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(),
+ attrs.active.handle_id);
SendRegistrationObjectDestroyed(thread_safe_sender_.get(), info.handle_id);
}
@@ -90,13 +97,13 @@ void ServiceWorkerMessageFilter::OnStaleSetVersionAttributes(
int provider_id,
int registration_handle_id,
int changed_mask,
- const ServiceWorkerVersionAttributes& attributes) {
+ const ServiceWorkerVersionAttributes& attrs) {
SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(),
- attributes.installing.handle_id);
+ attrs.installing.handle_id);
SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(),
- attributes.waiting.handle_id);
+ attrs.waiting.handle_id);
SendServiceWorkerObjectDestroyed(thread_safe_sender_.get(),
- attributes.active.handle_id);
+ attrs.active.handle_id);
SendRegistrationObjectDestroyed(thread_safe_sender_.get(),
registration_handle_id);
}
« no previous file with comments | « content/child/service_worker/service_worker_message_filter.h ('k') | content/child/service_worker/web_service_worker_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698