Fix labels in import data overlay.

Fix labels in import data overlay.

1. you can now click in the space between the text and checkbox
2. clicking on the text now works consistently (due to removing selectability)

BUG=408344
Committed: https://crrev.com/011b3c29f20c86a34ae12007ad70075bec422976
Cr-Commit-Position: refs/heads/master@{#292946}

[Evan Stade, 2014-08-28 17:12:39]

estade@chromium.org changed reviewers:
+ dbeam@chromium.org, dconnelly@chromium.org

[dconnelly, 2014-08-29 08:16:28]

https://codereview.chromium.org/517433002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/import_data_overlay.html (left):

https://codereview.chromium.org/517433002/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/import_data_overlay.html:61:
pref="import_search_engine">
I don't think you can change these this easily. I patched this in, and loading
chrome://settings/importData hits a NOTREACHED():

[80389:1287:0829/101203:FATAL:core_options_handler.cc(373)] Check failed: false.

Maybe you're building in Release? Looks like the C++ side searches the
PrefService for Prefs that have these names.

[Evan Stade, 2014-08-29 15:15:17]

https://codereview.chromium.org/517433002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/import_data_overlay.html (left):

https://codereview.chromium.org/517433002/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/import_data_overlay.html:61:
pref="import_search_engine">
On 2014/08/29 08:16:28, dconnelly wrote:
> I don't think you can change these this easily. I patched this in, and loading
> chrome://settings/importData hits a NOTREACHED():
> 
> [80389:1287:0829/101203:FATAL:core_options_handler.cc(373)] Check failed:
false.
> 
> Maybe you're building in Release? Looks like the C++ side searches the
> PrefService for Prefs that have these names.

you're right, was building in release. Thanks for catching this. The pref name
changes were completely unintentional.

[Evan Stade, 2014-08-29 18:22:49]

update, ptal. I also don't know why I added the bubble-button class.

[dconnelly, 2014-09-02 08:15:35]

lgtm. Sorry for the delay.

[Evan Stade, 2014-09-02 15:42:19]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-02 15:43:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/517433002/40001

[commit-bot: I haz the power, 2014-09-02 16:50:32]

Committed patchset #3 (id:40001) as 05f2eb4d434e0c0e2b1f6d0f8e3744f2d449c8dc

[Dan Beam, 2014-09-03 21:31:33]

lgtm

[commit-bot: I haz the power, 2014-09-10 03:19:06]

Patchset 3 (id:??) landed as
https://crrev.com/011b3c29f20c86a34ae12007ad70075bec422976
Cr-Commit-Position: refs/heads/master@{#292946}