Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/resources/options/import_data_overlay.html

Issue 517433002: Fix labels in import data overlay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert inadvertent changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/controlled_setting.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/import_data_overlay.html
diff --git a/chrome/browser/resources/options/import_data_overlay.html b/chrome/browser/resources/options/import_data_overlay.html
index 4aca7cfcb4c843eb765681bab32d102f873d4928..ecaa91e86fec74e74a93f3282deac63070dd4dc1 100644
--- a/chrome/browser/resources/options/import_data_overlay.html
+++ b/chrome/browser/resources/options/import_data_overlay.html
@@ -11,57 +11,44 @@
</div>
<div id="import-checkboxes">
<div i18n-content="importDescription"></div>
- <div class="checkbox">
- <span id="import-history-with-label"
- class="controlled-setting-with-label">
+ <div class="checkbox controlled-setting-with-label"
+ id="import-history-with-label">
+ <label>
<input id="import-history" type="checkbox" pref="import_history">
- <span>
- <label for="import-history" i18n-content="importHistory"></label>
- <span class="controlled-setting-indicator" pref="import_history">
- </span>
- </span>
+ <span i18n-content="importHistory"></span>
+ </label>
+ <span class="controlled-setting-indicator" pref="import_history">
</span>
</div>
- <div class="checkbox">
- <span id="import-favorites-with-label"
- class="controlled-setting-with-label">
+ <div class="checkbox controlled-setting-with-label"
+ id="import-favorites-with-label">
+ <label>
<input id="import-favorites" type="checkbox"
pref="import_bookmarks">
- <span>
- <label for="import-favorites" i18n-content="importFavorites">
- </label>
- <span class="controlled-setting-indicator"
- pref="import_bookmarks">
- </span>
- </span>
- </span>
+ <span i18n-content="importFavorites"></span>
+ </label>
+ <span class="controlled-setting-indicator"
+ pref="import_bookmarks"></span>
</div>
- <div class="checkbox">
- <span id="import-passwords-with-label"
- class="controlled-setting-with-label">
+ <div class="checkbox controlled-setting-with-label"
+ id="import-passwords-with-label">
+ <label>
<input id="import-passwords" type="checkbox"
pref="import_saved_passwords">
- <span>
- <label for="import-passwords" i18n-content="importPasswords">
- </label>
- <span class="controlled-setting-indicator"
- pref="import_saved_passwords">
- </span>
- </span>
- </span>
+ <span i18n-content="importPasswords"></span>
+ </label>
+ <span class="controlled-setting-indicator"
+ pref="import_saved_passwords"></span>
</div>
- <div class="checkbox">
- <span id="import-search-with-label"
- class="controlled-setting-with-label">
+ <div class="checkbox controlled-setting-with-label"
+ id="import-search-with-label">
+ <label>
<input id="import-search" type="checkbox"
pref="import_search_engine">
- <span>
- <label for="import-search" i18n-content="importSearch"></label>
- <span class="controlled-setting-indicator"
- pref="import_search_engine">
- </span>
- </span>
- </span>
+ <span i18n-content="importSearch"></span>
+ </label>
+ <span class="controlled-setting-indicator"
+ pref="import_search_engine"></span>
</div>
</div>
</div>
@@ -74,20 +61,15 @@
</div>
<div id="import-find-your-bookmarks">
<span i18n-content="findYourImportedBookmarks"></span>
- <div class="checkbox">
- <span class="controlled-setting-with-label">
+ <div class="checkbox controlled-setting-with-label">
+ <label>
<input id="import-data-show-bookmarks-bar"
pref="bookmark_bar.show_on_all_tabs"
metric="Options_ShowBookmarksBar" type="checkbox">
- <span>
- <label for="import-data-show-bookmarks-bar"
- i18n-content="toolbarShowBookmarksBar">
- </label>
- <span class="controlled-setting-indicator"
- pref="bookmark_bar.show_on_all_tabs">
- </span>
- </span>
- </span>
+ <span i18n-content="toolbarShowBookmarksBar"></span>
+ </label>
+ <span class="controlled-setting-indicator"
+ pref="bookmark_bar.show_on_all_tabs"></span>
</div>
</div>
</div>
« no previous file with comments | « chrome/browser/resources/options/controlled_setting.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698