chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 517413002: Compile chrome://settings, part 1: remove all warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 517413002: Compile chrome://settings, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/manage_profile_overlay.js ('k') | chrome/browser/resources/options/search_page.js » ('j') | chrome/browser/resources/options/startup_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index 0be060294d4fd1a262fa3a7f2eac2dff03c9beb8..d81258eedcd3ccf8286cdb91914af57aaa00ce7f 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -11,7 +11,7 @@ cr.define('options.search_engines', function() {

/**

* Creates a new search engine list item.

- * @param {Object} searchEnigne The search engine this represents.

+ * @param {Object} searchEngine The search engine this represents.

* @constructor

* @extends {cr.ui.ListItem}

@@ -235,7 +235,7 @@ cr.define('options.search_engines', function() {

* @param {Event} e The cancel event.

* @private

- onEditCancelled_: function() {

+ onEditCancelled_: function(e) {

chrome.send('searchEngineEditCancelled');

// The name field has been automatically set to match the display name,