chrome/browser/resources/options/startup_overlay.js - Issue 517413002: Compile chrome://settings, part 1: remove all warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/startup_overlay.js

Issue 517413002: Compile chrome://settings, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/startup_overlay.js

diff --git a/chrome/browser/resources/options/startup_overlay.js b/chrome/browser/resources/options/startup_overlay.js

index 15dea43afe35aa5a01bd332362984d3dd33d2c19..778c2524fee4669ed188a630398adbd7d2c263c5 100644

--- a/chrome/browser/resources/options/startup_overlay.js

+++ b/chrome/browser/resources/options/startup_overlay.js

@@ -106,7 +106,7 @@ cr.define('options', function() {

/**

* Handles change events of the preference

* 'session.startup_urls'.

- * @param {event} preference changed event.

+ * @param {event} event Preference changed event.

Dan Beam 2014/09/06 01:52:56 shouldn't this be Event?

Vitaly Pavlenko 2014/09/06 18:43:10 Done. That was classified as error, that's why I s

* @private

handleStartupPageListChange_: function(event) {

@@ -139,7 +139,7 @@ cr.define('options', function() {

/**

* Updates the autocomplete suggestion list with the given entries.

- * @param {Array} pages List of autocomplete suggestions.

+ * @param {Array} suggestions List of autocomplete suggestions.

* @private

updateAutocompleteSuggestions_: function(suggestions) {

« no previous file with comments | « chrome/browser/resources/options/search_page.js ('k') | chrome/browser/resources/options/website_settings.js » ('j') | no next file with comments »