chrome/browser/resources/options/language_options.js - Issue 517413002: Compile chrome://settings, part 1: remove all warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/language_options.js

Issue 517413002: Compile chrome://settings, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/language_list.js ('k') | chrome/browser/resources/options/manage_profile_overlay.js » ('j') | chrome/browser/resources/options/startup_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/language_options.js

diff --git a/chrome/browser/resources/options/language_options.js b/chrome/browser/resources/options/language_options.js

index 889929f3bc1765f341aa1caf94b505ac2eda6368..4e4e00de33b4a3579781c2fd3f46761287fd5797 100644

--- a/chrome/browser/resources/options/language_options.js

+++ b/chrome/browser/resources/options/language_options.js

@@ -84,13 +84,14 @@ cr.define('options', function() {

LanguageOptions.prototype = {

__proto__: Page.prototype,

- /* For recording the prospective language (the next locale after relaunch).

+ /**

+ * For recording the prospective language (the next locale after relaunch).

* @type {?string}

* @private

prospectiveUiLanguageCode_: null,

- /*

+ /**

* Map from language code to spell check dictionary download status for that

* language.

* @type {Array}

@@ -912,7 +913,7 @@ cr.define('options', function() {

* @param {Event} e Change event.

* @private

- updateEnableSpellCheck_: function() {

+ updateEnableSpellCheck_: function(e) {

var value = !$('enable-spell-check').checked;

$('language-options-spell-check-language-button').disabled = value;

if (!cr.IsMac)

@@ -1298,7 +1299,7 @@ cr.define('options', function() {

}

- /*

+ /**

* Converts the language code for Translation. There are some differences

* between the language set for Translation and that for Accept-Language.

* @param {string} languageCode The language code like 'fr'.