chrome/browser/resources/options/home_page_overlay.js - Issue 517413002: Compile chrome://settings, part 1: remove all warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/home_page_overlay.js

Issue 517413002: Compile chrome://settings, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/handler_options.js ('k') | chrome/browser/resources/options/hotword_confirm_dialog.js » ('j') | chrome/browser/resources/options/startup_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/home_page_overlay.js

diff --git a/chrome/browser/resources/options/home_page_overlay.js b/chrome/browser/resources/options/home_page_overlay.js

index b48fefc7bebce27622d464c6489d94a60d7f01ba..84d3a788932bd3e68b18e495a7550228d416d21d 100644

--- a/chrome/browser/resources/options/home_page_overlay.js

+++ b/chrome/browser/resources/options/home_page_overlay.js

@@ -9,7 +9,8 @@ cr.define('options', function() {

/**

* HomePageOverlay class

* Dialog that allows users to set the home page.

- * @extends {SettingsDialog}

+ * @constructor

+ * @extends {options.SettingsDialog}

function HomePageOverlay() {

SettingsDialog.call(this, 'homePageOverlay',

@@ -74,7 +75,7 @@ cr.define('options', function() {

* enabled only if the homepage is not the NTP. The indicator is always

* enabled but treats the input's value as read-only if the homepage is the

* NTP.

- * @param {Event} Pref change event.

+ * @param {Event} event Pref change event.

handleHomepageIsNTPPrefChange: function(event) {

var urlField = $('homepage-url-field');

@@ -106,7 +107,7 @@ cr.define('options', function() {

/**

* Updates the autocomplete suggestion list with the given entries.

- * @param {Array} pages List of autocomplete suggestions.

+ * @param {Array} suggestions List of autocomplete suggestions.

* @private

updateAutocompleteSuggestions_: function(suggestions) {