Compile chrome://settings, part 1: remove all warnings

Compile chrome://settings, part 1: remove all warnings

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep WARNING

Committed: https://crrev.com/cede2dd668af4891ab61611242364e9f79c1d65e
Cr-Commit-Position: refs/heads/master@{#293636}

[Dan Beam, 2014-09-06 01:52:55]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2014-09-06 01:52:56]

lgtm

lgtm w/nit

https://codereview.chromium.org/517413002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/startup_overlay.js (right):

https://codereview.chromium.org/517413002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/startup_overlay.js:109: * @param {event} event
Preference changed event.
shouldn't this be Event?

[commit-bot: I haz the power, 2014-09-06 01:53:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalyp@chromium.org/517413002/1

[commit-bot: I haz the power, 2014-09-06 02:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 02:09:08]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/52480)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Vitaly Pavlenko, 2014-09-06 18:43:10]

https://codereview.chromium.org/517413002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/startup_overlay.js (right):

https://codereview.chromium.org/517413002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/startup_overlay.js:109: * @param {event} event
Preference changed event.
On 2014/09/06 01:52:56, Dan Beam wrote:
> shouldn't this be Event?

Done. That was classified as error, that's why I skipped it initially.

[Vitaly Pavlenko, 2014-09-06 18:43:17]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-06 18:44:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalyp@chromium.org/517413002/20001

[commit-bot: I haz the power, 2014-09-06 21:03:13]

Committed patchset #2 (id:20001) as 98407660295e1364c6247cbbb9393edec98ea22b

[commit-bot: I haz the power, 2014-09-10 03:43:23]

Patchset 2 (id:??) landed as
https://crrev.com/cede2dd668af4891ab61611242364e9f79c1d65e
Cr-Commit-Position: refs/heads/master@{#293636}