Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2452)

Unified Diff: chrome/browser/resources/options/language_list.js

Issue 517413002: Compile chrome://settings, part 1: remove all warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master
Patch Set: s/event/Event/ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_list.js
diff --git a/chrome/browser/resources/options/language_list.js b/chrome/browser/resources/options/language_list.js
index d4ea5bd4f220641a5ed749b14bcaa4989f67a789..e5f16285c3ff4f1cb1f781fb359921040df2c10e 100644
--- a/chrome/browser/resources/options/language_list.js
+++ b/chrome/browser/resources/options/language_list.js
@@ -76,7 +76,7 @@ cr.define('options', function() {
}
return this.languageCodeToLanguageInfo_[languageCode];
- }
+ };
/**
* Returns true if the given language code is valid.
@@ -89,7 +89,7 @@ cr.define('options', function() {
return true;
}
return false;
- }
+ };
LanguageList.prototype = {
__proto__: DeletableItemList.prototype,
@@ -150,7 +150,7 @@ cr.define('options', function() {
}
},
- /*
+ /**
* Adds a language to the language list.
* @param {string} languageCode language code (ex. "fr").
*/
@@ -167,30 +167,30 @@ cr.define('options', function() {
this.savePreference_();
},
- /*
+ /**
* Gets the language codes of the currently listed languages.
*/
getLanguageCodes: function() {
return this.dataModel.slice();
},
- /*
+ /**
* Clears the selection
*/
clearSelection: function() {
this.selectionModel.unselectAll();
},
- /*
+ /**
* Gets the language code of the selected language.
*/
getSelectedLanguageCode: function() {
return this.selectedItem;
},
- /*
+ /**
* Selects the language by the given language code.
- * @returns {boolean} True if the operation is successful.
+ * @return {boolean} True if the operation is successful.
*/
selectLanguageByCode: function(languageCode) {
var index = this.dataModel.indexOf(languageCode);
@@ -213,7 +213,7 @@ cr.define('options', function() {
return index;
},
- /*
+ /**
* Computes the target item of drop event.
* @param {Event} e The drop or dragover event.
* @private
@@ -227,7 +227,7 @@ cr.define('options', function() {
return target;
},
- /*
+ /**
* Handles the dragstart event.
* @param {Event} e The dragstart event.
* @private
@@ -246,7 +246,7 @@ cr.define('options', function() {
}
},
- /*
+ /**
* Handles the dragenter event.
* @param {Event} e The dragenter event.
* @private
@@ -255,7 +255,7 @@ cr.define('options', function() {
e.preventDefault();
},
- /*
+ /**
* Handles the dragover event.
* @param {Event} e The dragover event.
* @private
@@ -280,7 +280,7 @@ cr.define('options', function() {
e.preventDefault();
},
- /*
+ /**
* Handles the drop event.
* @param {Event} e The drop event.
* @private
@@ -304,7 +304,7 @@ cr.define('options', function() {
this.savePreference_();
},
- /*
+ /**
* Handles the dragleave event.
* @param {Event} e The dragleave event
* @private
@@ -313,7 +313,7 @@ cr.define('options', function() {
this.hideDropMarker_();
},
- /*
+ /**
* Shows and positions the marker to indicate the drop target.
* @param {HTMLElement} target The current target list item of drop
* @param {string} pos 'below' or 'above'
@@ -334,7 +334,7 @@ cr.define('options', function() {
marker.style.display = 'block';
},
- /*
+ /**
* Hides the drop marker.
* @private
*/
« no previous file with comments | « chrome/browser/resources/options/import_data_overlay.js ('k') | chrome/browser/resources/options/language_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698