[Android checkstyle] Allow underscores in package names.

[Android checkstyle] Allow underscores in package names.

Committed: https://crrev.com/5ce7d0cb86e3db560bcb06cafb6b218490625800
Cr-Commit-Position: refs/heads/master@{#292730}

[newt (away), 2014-08-29 18:10:29]

newt@chromium.org changed reviewers:
+ aurimas@chromium.org

[newt (away), 2014-08-29 18:10:30]

PTAL

Existing uses of underscores include org.chromium.content_shell and
org.chromium.android_webview.

[aurimas (slooooooooow), 2014-08-29 18:35:43]

On 2014/08/29 18:10:30, newt wrote:
> PTAL
> 
> Existing uses of underscores include org.chromium.content_shell and
> org.chromium.android_webview.

I think this is terrible naming from our part. Google Java Style [1] (which
Android extends, right?) says that package names should not have underscores.
The naming is clearly coming from C++ developers. We should rename
org.chromium.android_webview to org.chromium.androidwebview and similarly for
content_shell.

[1]
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s5.2.1-pack...

[newt (away), 2014-08-29 18:57:53]

Meh. Google Java style guide doesn't technically apply to us, but it's nice to
follow it when possible. I was just hoping to align checkstyle with our
codebase; it could also be done by renaming the offending packages.

(Though personally, I find android_webview more readable than androidwebview.)

[aurimas (slooooooooow), 2014-08-29 20:02:24]

On 2014/08/29 18:57:53, newt wrote:
> Meh. Google Java style guide doesn't technically apply to us, but it's nice to
> follow it when possible. I was just hoping to align checkstyle with our
> codebase; it could also be done by renaming the offending packages.
> 
> (Though personally, I find android_webview more readable than androidwebview.)

LGTM. Fine - we can allow underscores. Can you make this into an error then?

[newt (away), 2014-08-29 20:09:32]

The CQ bit was checked by newt@chromium.org

[newt (away), 2014-08-29 20:10:13]

Ok, landing this for now. We can always update the rule if/when we decide to
rename all offending packages.

[commit-bot: I haz the power, 2014-08-30 00:17:45]

Committed patchset #2 (id:20001) as 5a7a5310c9699642897f47340aaba6183bb1c70e

[commit-bot: I haz the power, 2014-09-10 03:12:13]

Patchset 2 (id:??) landed as
https://crrev.com/5ce7d0cb86e3db560bcb06cafb6b218490625800
Cr-Commit-Position: refs/heads/master@{#292730}