Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 517403002: [Android checkstyle] Allow underscores in package names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: warning -> error Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/checkstyle/chromium-style-5.0.xml
diff --git a/tools/android/checkstyle/chromium-style-5.0.xml b/tools/android/checkstyle/chromium-style-5.0.xml
index 7a50d31555a8e093dc4e0614dc15bf591e95916a..6ddd2301e1e922da07622f9e69bcf55edee52161 100644
--- a/tools/android/checkstyle/chromium-style-5.0.xml
+++ b/tools/android/checkstyle/chromium-style-5.0.xml
@@ -38,8 +38,8 @@
<property name="allowMissingThrowsTags" value="true"/>
</module>
<module name="PackageName">
- <property name="severity" value="warning"/>
- <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/>
+ <property name="severity" value="error"/>
+ <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]{1,})*$"/>
</module>
<module name="TypeName">
<property name="severity" value="warning"/>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698