runtime/vm/flow_graph_compiler_ia32.cc - Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index f494d7f305759ba19cbe7ecfd31eb31cddf0f504..616ce726cefd23fddab6da99506c59bb3505dc39 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -1407,6 +1407,10 @@ void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,

// This function must be in sync with FlowGraphCompiler::RecordSafepoint and

// FlowGraphCompiler::SlowPathEnvironmentFor.

void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {

+#if defined(DEBUG)

+ locs->CheckWritableInputs();

+#endif

// TODO(vegorov): consider saving only caller save (volatile) registers.

const intptr_t xmm_regs_count = locs->live_registers()->FpuRegisterCount();

if (xmm_regs_count > 0) {

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »