Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 517223002: ServiceWorker: Tweak layout tests based on the latest install sequence (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Tweak layout tests based on the latest install sequence [1] Blink: https://codereview.chromium.org/524193003/ [2] Chromium: https://codereview.chromium.org/517493002/ [3] Blink: THIS PATCH BUG=406240 TEST=run_webkit_tests.py --debug http/tests/serviceworker/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181168

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : enable tests #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/activation-after-registration.html View 1 chunk +12 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html View 1 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/installing.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-end-to-end.html View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-service-worker-attributes.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
nhiroki
Ptal, thanks!
6 years, 3 months ago (2014-09-01 03:24:47 UTC) #2
horo
lgtm
6 years, 3 months ago (2014-09-01 03:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/517223002/80001
6 years, 3 months ago (2014-09-01 06:19:18 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 3 months ago (2014-09-01 07:21:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/25047)
6 years, 3 months ago (2014-09-01 08:22:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/517223002/80001
6 years, 3 months ago (2014-09-01 08:38:57 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 09:21:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as 181168

Powered by Google App Engine
This is Rietveld 408576698