LayoutTests/http/tests/serviceworker/registration-end-to-end.html - Issue 517223002: ServiceWorker: Tweak layout tests based on the latest install sequence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/registration-end-to-end.html

Issue 517223002: ServiceWorker: Tweak layout tests based on the latest install sequence (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/installing.html ('k') | LayoutTests/http/tests/serviceworker/registration-service-worker-attributes.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/registration-end-to-end.html

diff --git a/LayoutTests/http/tests/serviceworker/registration-end-to-end.html b/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

index 877bd26ad3be33ea2adf28ce6155b344bbe82efe..ac99d5c1853e96b24c17e6df3ed755897db1c9c8 100644

--- a/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

+++ b/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

@@ -23,9 +23,6 @@ t.step(function() {

service_worker_unregister_and_register(

t, 'resources/end-to-end-worker.js', scope)

- .then(function(registration) {

- return wait_for_update(t, registration);

- })

.then(onRegister)

.catch(unreached_rejection(t));

@@ -35,7 +32,8 @@ t.step(function() {

return messageChannel.port1;

}

- function onRegister(sw) {

+ function onRegister(registration) {

+ var sw = registration.installing;

serviceWorkerStates.push(sw.state);

lastServiceWorkerState = sw.state;