Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: Source/core/frame/FrameConsole.h

Issue 517213003: Oilpan: fix build after r181083 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameConsole.h
diff --git a/Source/core/frame/FrameConsole.h b/Source/core/frame/FrameConsole.h
index 74f8e1787b6e1358ba5b8a0ba7db20bd12d9e5bd..a44784098ad5ec91751101c4cd6e79f817c3aa5c 100644
--- a/Source/core/frame/FrameConsole.h
+++ b/Source/core/frame/FrameConsole.h
@@ -45,10 +45,12 @@ class WorkerGlobalScopeProxy;
// FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
// It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
-class FrameConsole FINAL {
+class FrameConsole FINAL : public NoBaseWillBeGarbageCollected<FrameConsole> {
public:
- static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr(new FrameConsole(frame)); }
- ~FrameConsole();
Mads Ager (chromium) 2014/08/29 09:54:41 Looking at the trybots it looks like the removal o
+ static PassOwnPtrWillBeRawPtr<FrameConsole> create(LocalFrame& frame)
+ {
+ return adoptPtrWillBeNoop(new FrameConsole(frame));
+ }
void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>);
void adoptWorkerConsoleMessages(WorkerGlobalScopeProxy*);
@@ -60,12 +62,14 @@ public:
ConsoleMessageStorage* messageStorage();
+ void trace(Visitor*);
+
private:
explicit FrameConsole(LocalFrame&);
LocalFrame& m_frame;
- OwnPtr<ConsoleMessageStorage> m_consoleMessageStorage;
+ OwnPtrWillBeMember<ConsoleMessageStorage> m_consoleMessageStorage;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698