Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/frame/FrameConsole.h

Issue 517213003: Oilpan: fix build after r181083 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 27 matching lines...) Expand all
38 namespace blink { 38 namespace blink {
39 39
40 class ConsoleMessage; 40 class ConsoleMessage;
41 class ConsoleMessageStorage; 41 class ConsoleMessageStorage;
42 class FrameHost; 42 class FrameHost;
43 class ScriptCallStack; 43 class ScriptCallStack;
44 class WorkerGlobalScopeProxy; 44 class WorkerGlobalScopeProxy;
45 45
46 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector. 46 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
47 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console. 47 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
48 class FrameConsole FINAL { 48 class FrameConsole FINAL : public NoBaseWillBeGarbageCollected<FrameConsole> {
49 public: 49 public:
50 static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr( new FrameConsole(frame)); } 50 static PassOwnPtrWillBeRawPtr<FrameConsole> create(LocalFrame& frame)
51 ~FrameConsole(); 51 {
Mads Ager (chromium) 2014/08/29 09:54:41 Looking at the trybots it looks like the removal o
52 return adoptPtrWillBeNoop(new FrameConsole(frame));
53 }
52 54
53 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>); 55 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>);
54 void adoptWorkerConsoleMessages(WorkerGlobalScopeProxy*); 56 void adoptWorkerConsoleMessages(WorkerGlobalScopeProxy*);
55 57
56 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>); 58 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>);
57 59
58 static void mute(); 60 static void mute();
59 static void unmute(); 61 static void unmute();
60 62
61 ConsoleMessageStorage* messageStorage(); 63 ConsoleMessageStorage* messageStorage();
62 64
65 void trace(Visitor*);
66
63 private: 67 private:
64 explicit FrameConsole(LocalFrame&); 68 explicit FrameConsole(LocalFrame&);
65 69
66 LocalFrame& m_frame; 70 LocalFrame& m_frame;
67 71
68 OwnPtr<ConsoleMessageStorage> m_consoleMessageStorage; 72 OwnPtrWillBeMember<ConsoleMessageStorage> m_consoleMessageStorage;
69 }; 73 };
70 74
71 } // namespace blink 75 } // namespace blink
72 76
73 #endif // FrameConsole_h 77 #endif // FrameConsole_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698