Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 517213003: Oilpan: fix build after r181083 (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
blink-reviews, falken, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r181083 Move FrameConsole and ConsoleMessageStorage to the heap in order to do so. R=ager@chromium.org, zerny@chromium.org BUG=408121 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181087

Patch Set 1 #

Total comments: 1

Patch Set 2 : Re-intro ~FrameConsole non-Oilpan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -27 lines) Patch
M Source/core/frame/FrameConsole.h View 1 2 chunks +9 lines, -4 lines 0 comments Download
M Source/core/frame/FrameConsole.cpp View 1 2 chunks +6 lines, -3 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +15 lines, -12 lines 0 comments Download
M Source/core/inspector/ConsoleMessageStorage.cpp View 3 chunks +10 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
6 years, 3 months ago (2014-08-29 09:44:43 UTC) #1
sof
Please take a look.
6 years, 3 months ago (2014-08-29 09:44:43 UTC) #2
zerny-chromium
zerny@chromium.org changed reviewers: + zerny@chromium.org
6 years, 3 months ago (2014-08-29 09:47:12 UTC) #3
zerny-chromium
lgtm
6 years, 3 months ago (2014-08-29 09:47:12 UTC) #4
Mads Ager (chromium)
ager@chromium.org changed reviewers: + ager@chromium.org
6 years, 3 months ago (2014-08-29 09:54:41 UTC) #5
Mads Ager (chromium)
LGTM https://codereview.chromium.org/517213003/diff/1/Source/core/frame/FrameConsole.h File Source/core/frame/FrameConsole.h (left): https://codereview.chromium.org/517213003/diff/1/Source/core/frame/FrameConsole.h#oldcode51 Source/core/frame/FrameConsole.h:51: ~FrameConsole(); Looking at the trybots it looks like ...
6 years, 3 months ago (2014-08-29 09:54:41 UTC) #6
sof
On 2014/08/29 09:54:41, Mads Ager (chromium) wrote: > LGTM > > https://codereview.chromium.org/517213003/diff/1/Source/core/frame/FrameConsole.h > File Source/core/frame/FrameConsole.h ...
6 years, 3 months ago (2014-08-29 09:58:38 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 3 months ago (2014-08-29 10:06:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/517213003/20001
6 years, 3 months ago (2014-08-29 10:07:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 181087
6 years, 3 months ago (2014-08-29 10:07:44 UTC) #10
haraken
6 years, 3 months ago (2014-08-29 10:09:48 UTC) #11
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698