Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 517123002: Add gamma/sRGB tags to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add gamma/sRGB tags to SkImageInfo requires this CL to land in chrome https://codereview.chromium.org/517803002/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/228b285ba14a6e9b6d1cc95ea1583caab30168a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -46 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +64 lines, -25 lines 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +111 lines, -21 lines 0 comments Download
A tests/ImageInfoTest.cpp View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
reed@google.com changed reviewers: + fmalita@google.com
6 years, 3 months ago (2014-08-28 22:03:06 UTC) #1
reed1
6 years, 3 months ago (2014-08-28 22:03:06 UTC) #2
f(malita)
fmalita@chromium.org changed reviewers: + fmalita@chromium.org
6 years, 3 months ago (2014-08-28 22:30:18 UTC) #3
f(malita)
rslgtm
6 years, 3 months ago (2014-08-28 22:30:18 UTC) #4
f(malita)
On 2014/08/28 22:30:18, Florin Malita wrote: > rslgtm (apparently not recognized for Skia:) LGTM
6 years, 3 months ago (2014-08-28 22:31:07 UTC) #5
reed2
The CQ bit was checked by reed@chromium.org
6 years, 3 months ago (2014-08-29 10:59:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/517123002/1
6 years, 3 months ago (2014-08-29 11:00:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 228b285ba14a6e9b6d1cc95ea1583caab30168a1
6 years, 3 months ago (2014-08-29 11:08:50 UTC) #8
reed1
6 years, 3 months ago (2014-08-29 14:48:34 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/519583004/ by reed@google.com.

The reason for reverting is: Seems to be triggering assert in blink

SSLUITest.TestRedirectHTTPToBadHTTPS (run #1):
[ RUN      ] SSLUITest.TestRedirectHTTPToBadHTTPS
HTTP server started on http://127.0.0.1:58000...
sending server_data: {"host": "127.0.0.1", "port": 58000} (36 bytes)
HTTPS server started on https://127.0.0.1:58009...
sending server_data: {"host": "127.0.0.1", "port": 58009} (36 bytes)
ASSERTION FAILED: info.fAlphaType == m_imageInfo.fAlphaType
../../third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp(78)
: virtual bool blink::DecodingImageGenerator::onGetPixels(const SkImageInfo &,
void *, size_t, SkPMColor *, int *)
1   0x77eb0d3 blink::DecodingImageGenerator::onGetPixels(SkImageInfo const&,
void*, unsigned long, unsigned int*, int*)
2   0x92edddc SkImageGenerator::getPixels(SkImageInfo const&, void*, unsigned
long, unsigned int*, int*)
3   0x92adf78 SkDiscardablePixelRef::onNewLockPixels(SkPixelRef::LockRec*)
4   0x9369283 SkPixelRef::lockPixels(SkPixelRef::LockRec*)
5   0x9369433 SkPixelRef::lockPixels()
6   0x9213344 SkBitmap::lockPixels() const
7   0x921ca57 SkAutoLockPixels::SkAutoLockPixels(SkBitmap const&, bool)
8   0x921ad80 SkAutoLockPixels::SkAutoLockPixels(SkBitmap const&, bool)
9   0x92b7125 SkDraw::drawBitmap(SkBitmap const&, SkMatrix const&, SkPaint
const&) const
10  0x921f4fb SkBitmapDevice::drawBitmap(SkDraw const&, SkBitmap const&,
SkMatrix const&, SkPaint const&)
11  0x921f8c7 SkBitmapDevice::drawBitmapRect(SkDraw const&, SkBitmap const&,
SkRect const*, SkRect const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags)
12  0x9288e12 SkCanvas::internalDrawBitmapRect(SkBitmap const&, SkRect const*,
SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
13  0x9288ee9 SkCanvas::drawBitmapRectToRect(SkBitmap const&, SkRect const*,
SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
.

Powered by Google App Engine
This is Rietveld 408576698