Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: Source/web/PopupMenuTest.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/PopupMenuTest.cpp
diff --git a/Source/web/PopupMenuTest.cpp b/Source/web/PopupMenuTest.cpp
index 374cd4ad2d30a0372b3871a4edad5e7414213b33..3b82ddfb49eada90c3bc81598e4fed69192c3126 100644
--- a/Source/web/PopupMenuTest.cpp
+++ b/Source/web/PopupMenuTest.cpp
@@ -190,12 +190,11 @@ protected:
virtual void SetUp()
{
m_helper.initialize(false, 0, &m_webviewClient);
- m_popupMenu = adoptRef(new PopupMenuChromium(*mainFrame()->frame(), &m_popupMenuClient));
+ m_popupMenu = adoptRefWillBeNoop(new PopupMenuChromium(*mainFrame()->frame(), &m_popupMenuClient));
}
virtual void TearDown()
{
- m_popupMenu = nullptr;
Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
}
@@ -266,7 +265,7 @@ protected:
protected:
PopupTestWebViewClient m_webviewClient;
TestPopupMenuClient m_popupMenuClient;
- RefPtr<PopupMenu> m_popupMenu;
+ RefPtrWillBePersistent<PopupMenu> m_popupMenu;
std::string baseURL;
private:
@@ -584,7 +583,6 @@ protected:
protected:
PopupTestWebViewClient m_webviewClient;
- RefPtr<PopupMenu> m_popupMenu;
std::string baseURL;
private:

Powered by Google App Engine
This is Rietveld 408576698