Source/web/AssociatedURLLoader.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/AssociatedURLLoader.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/AssociatedURLLoader.h

diff --git a/Source/web/AssociatedURLLoader.h b/Source/web/AssociatedURLLoader.h

index 1d111a94ec613d3788f70900bf897eea2b662693..c7032a34ce53c31174208be21e0ea1dd1ffc2afa 100644

--- a/Source/web/AssociatedURLLoader.h

+++ b/Source/web/AssociatedURLLoader.h

@@ -46,7 +46,7 @@ class WebLocalFrameImpl;

class AssociatedURLLoader FINAL : public WebURLLoader {

WTF_MAKE_NONCOPYABLE(AssociatedURLLoader);

public:

- AssociatedURLLoader(PassRefPtr<WebLocalFrameImpl>, const WebURLLoaderOptions&);

+ AssociatedURLLoader(PassRefPtrWillBeRawPtr<WebLocalFrameImpl>, const WebURLLoaderOptions&);

~AssociatedURLLoader();

// WebURLLoader methods:

@@ -59,7 +59,7 @@ private:

class ClientAdapter;

- RefPtr<WebLocalFrameImpl> m_frameImpl;

+ RefPtrWillBePersistent<WebLocalFrameImpl> m_frameImpl;

WebURLLoaderOptions m_options;

WebURLLoaderClient* m_client;

OwnPtr<ClientAdapter> m_clientAdapter;