Source/platform/PopupMenu.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/PopupMenu.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/PopupMenu.h

diff --git a/Source/platform/PopupMenu.h b/Source/platform/PopupMenu.h

index ad744d448b171478501c74d87cd12510452b004b..4e579ea4cf7f77afb330a82cdf578dcc2c7cf376 100644

--- a/Source/platform/PopupMenu.h

+++ b/Source/platform/PopupMenu.h

@@ -22,6 +22,7 @@

#define PopupMenu_h

#include "platform/PlatformExport.h"

+#include "platform/heap/Handle.h"

#include "wtf/RefCounted.h"

namespace blink {

@@ -29,9 +30,10 @@ namespace blink {

class FloatQuad;

class IntSize;

-class PopupMenu : public RefCounted<PopupMenu> {

+class PopupMenu : public RefCountedWillBeGarbageCollectedFinalized<PopupMenu> {

public:

virtual ~PopupMenu() { }

+ virtual void trace(Visitor*) { }

virtual void show(const FloatQuad& controlPosition, const IntSize& controlSize, int index) = 0;

virtual void hide() = 0;

virtual void updateFromElement() = 0;