Source/modules/geolocation/GeolocationController.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/GeolocationController.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/geolocation/GeolocationController.cpp

diff --git a/Source/modules/geolocation/GeolocationController.cpp b/Source/modules/geolocation/GeolocationController.cpp

index 6b88e83292b0a9aeec1ba8a59ba0a5f901366ebf..1189472b0598b3017924e362c7b9616dd9314aff 100644

--- a/Source/modules/geolocation/GeolocationController.cpp

+++ b/Source/modules/geolocation/GeolocationController.cpp

@@ -99,11 +99,6 @@ GeolocationController::~GeolocationController()

#endif

}

-void GeolocationController::persistentHostHasBeenDestroyed()

- observeContext(0);

PassOwnPtrWillBeRawPtr<GeolocationController> GeolocationController::create(LocalFrame& frame, GeolocationClient* client)

{

return adoptPtrWillBeNoop(new GeolocationController(frame, client));