Source/core/frame/RemoteFrameView.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RemoteFrameView.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/RemoteFrameView.h

diff --git a/Source/core/frame/RemoteFrameView.h b/Source/core/frame/RemoteFrameView.h

index 614e3a5e8015cc038f8468645442366eb3eff3e5..b6b29050b887361a31f2e7ed305637eb037d28b9 100644

--- a/Source/core/frame/RemoteFrameView.h

+++ b/Source/core/frame/RemoteFrameView.h

@@ -7,6 +7,7 @@

#include "platform/Widget.h"

#include "platform/geometry/IntRect.h"

+#include "platform/heap/Handle.h"

namespace blink {

@@ -32,7 +33,10 @@ public:

private:

explicit RemoteFrameView(RemoteFrame*);

- RefPtr<RemoteFrame> m_remoteFrame;

+ // The RefPtrWillBePersistent-cycle between RemoteFrame and its RemoteFrameView

+ // is broken in the same manner as FrameView::m_frame and LocalFrame::m_view is.

+ // See the FrameView::m_frame comment.

+ RefPtrWillBePersistent<RemoteFrame> m_remoteFrame;

};

DEFINE_TYPE_CASTS(RemoteFrameView, Widget, widget, widget->isRemoteFrameView(), widget.isRemoteFrameView());