Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: Source/core/frame/RemoteFrame.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/RemoteFrame.cpp
diff --git a/Source/core/frame/RemoteFrame.cpp b/Source/core/frame/RemoteFrame.cpp
index ae7408abaf2b4476e58f467480ff6a6449d0df8c..54ebd930fefbe39eb35bebbe19099f2c94046a94 100644
--- a/Source/core/frame/RemoteFrame.cpp
+++ b/Source/core/frame/RemoteFrame.cpp
@@ -15,10 +15,9 @@ inline RemoteFrame::RemoteFrame(FrameClient* client, FrameHost* host, FrameOwner
{
}
-PassRefPtr<RemoteFrame> RemoteFrame::create(FrameClient* client, FrameHost* host, FrameOwner* owner)
+PassRefPtrWillBeRawPtr<RemoteFrame> RemoteFrame::create(FrameClient* client, FrameHost* host, FrameOwner* owner)
{
- RefPtr<RemoteFrame> frame = adoptRef(new RemoteFrame(client, host, owner));
- return frame.release();
+ return adoptRefWillBeNoop(new RemoteFrame(client, host, owner));
}
RemoteFrame::~RemoteFrame()
@@ -29,7 +28,7 @@ RemoteFrame::~RemoteFrame()
void RemoteFrame::detach()
{
detachChildren();
- m_host = 0;
+ m_host = nullptr;
}
void RemoteFrame::setView(PassRefPtr<RemoteFrameView> view)

Powered by Google App Engine
This is Rietveld 408576698