Source/core/frame/FrameConsole.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameConsole.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameConsole.h

diff --git a/Source/core/frame/FrameConsole.h b/Source/core/frame/FrameConsole.h

index fb94e1056c15dd6a2db1f9f6ebfb8f285c27ee31..194d5e8733cb39042e934793701f055dec3fbcce 100644

--- a/Source/core/frame/FrameConsole.h

+++ b/Source/core/frame/FrameConsole.h

@@ -73,8 +73,9 @@ public:

private:

explicit FrameConsole(LocalFrame&);

- LocalFrame& m_frame;

+ LocalFrame& frame() const { return *m_frame; }

haraken 2014/09/22 05:35:22 Add ASSERT(m_frame).

+ RawPtrWillBeMember<LocalFrame> m_frame;

OwnPtrWillBeMember<ConsoleMessageStorage> m_consoleMessageStorage;

};