Source/core/frame/FrameConsole.h - Issue 517043003: Move Frame to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/FrameConsole.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Apple Inc. All rights reserved.	2 * Copyright (C) 2013 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 static void unmute();	66 static void unmute();

67	67

68 ConsoleMessageStorage* messageStorage();	68 ConsoleMessageStorage* messageStorage();

69 void clearMessages();	69 void clearMessages();

70	70

71 void trace(Visitor*);	71 void trace(Visitor*);

72	72

73 private:	73 private:

74 explicit FrameConsole(LocalFrame&);	74 explicit FrameConsole(LocalFrame&);

75	75

76 LocalFrame& m_frame;	76 LocalFrame& frame() const { return *m_frame; }
	haraken 2014/09/22 05:35:22 Add ASSERT(m_frame). Add ASSERT(m_frame).
77	77

	78 RawPtrWillBeMember<LocalFrame> m_frame;

78 OwnPtrWillBeMember<ConsoleMessageStorage> m_consoleMessageStorage;	79 OwnPtrWillBeMember<ConsoleMessageStorage> m_consoleMessageStorage;

79 };	80 };

80	81

81 } // namespace blink	82 } // namespace blink

82	83

83 #endif // FrameConsole_h	84 #endif // FrameConsole_h

OLD	NEW

« Source/core/frame/Frame.cpp ('K') | « Source/core/frame/Frame.cpp ('k') | Source/core/frame/FrameConsole.cpp » ('j') | Source/core/frame/LocalDOMWindow.cpp » ('J')