Source/core/editing/FrameSelection.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FrameSelection.h

diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h

index 6dbee0c4b663649b9567cebd7bf35f5376d233e9..9e59970e7a65c6cd512c331622a09977b92fdc96 100644

--- a/Source/core/editing/FrameSelection.h

+++ b/Source/core/editing/FrameSelection.h

@@ -266,7 +266,7 @@ private:

VisibleSelection validateSelection(const VisibleSelection&);

- LocalFrame* m_frame;

+ RawPtrWillBeMember<LocalFrame> m_frame;

LayoutUnit m_xPosForVerticalArrowNavigation;