Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: Source/core/editing/FrameSelection.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 259
260 bool dispatchSelectStart(); 260 bool dispatchSelectStart();
261 261
262 void updateSelectionIfNeeded(const Position& base, const Position& extent, c onst Position& start, const Position& end); 262 void updateSelectionIfNeeded(const Position& base, const Position& extent, c onst Position& start, const Position& end);
263 263
264 void startObservingVisibleSelectionChange(); 264 void startObservingVisibleSelectionChange();
265 void stopObservingVisibleSelectionChangeIfNecessary(); 265 void stopObservingVisibleSelectionChangeIfNecessary();
266 266
267 VisibleSelection validateSelection(const VisibleSelection&); 267 VisibleSelection validateSelection(const VisibleSelection&);
268 268
269 LocalFrame* m_frame; 269 RawPtrWillBeMember<LocalFrame> m_frame;
270 270
271 LayoutUnit m_xPosForVerticalArrowNavigation; 271 LayoutUnit m_xPosForVerticalArrowNavigation;
272 272
273 VisibleSelection m_selection; 273 VisibleSelection m_selection;
274 bool m_observingVisibleSelection; 274 bool m_observingVisibleSelection;
275 VisiblePosition m_originalBase; // Used to store base before the adjustment at bidi boundary 275 VisiblePosition m_originalBase; // Used to store base before the adjustment at bidi boundary
276 TextGranularity m_granularity; 276 TextGranularity m_granularity;
277 277
278 // The range specified by the user, which may not be visually canonicalized (hence "logical"). 278 // The range specified by the user, which may not be visually canonicalized (hence "logical").
279 // This will be invalidated if the underlying VisibleSelection changes. If t hat happens, this variable will 279 // This will be invalidated if the underlying VisibleSelection changes. If t hat happens, this variable will
(...skipping 30 matching lines...) Expand all
310 } 310 }
311 } // namespace blink 311 } // namespace blink
312 312
313 #ifndef NDEBUG 313 #ifndef NDEBUG
314 // Outside the WebCore namespace for ease of invocation from gdb. 314 // Outside the WebCore namespace for ease of invocation from gdb.
315 void showTree(const blink::FrameSelection&); 315 void showTree(const blink::FrameSelection&);
316 void showTree(const blink::FrameSelection*); 316 void showTree(const blink::FrameSelection*);
317 #endif 317 #endif
318 318
319 #endif // FrameSelection_h 319 #endif // FrameSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698