Source/bindings/core/v8/PageScriptDebugServer.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/PageScriptDebugServer.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/message-port-gc-closed.html ('k') | Source/bindings/core/v8/ScriptController.cpp » ('j') | Source/core/editing/SpellChecker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/PageScriptDebugServer.cpp

diff --git a/Source/bindings/core/v8/PageScriptDebugServer.cpp b/Source/bindings/core/v8/PageScriptDebugServer.cpp

index 309cc2afcca12499c017cdb6693f299916f0d791..aebb9bbe0b09178b978d3fcf2ff1460e00323f9f 100644

--- a/Source/bindings/core/v8/PageScriptDebugServer.cpp

+++ b/Source/bindings/core/v8/PageScriptDebugServer.cpp

@@ -171,7 +171,7 @@ void PageScriptDebugServer::setClientMessageLoop(PassOwnPtr<ClientMessageLoop> c

void PageScriptDebugServer::compileScript(ScriptState* scriptState, const String& expression, const String& sourceURL, String* scriptId, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace)

{

ExecutionContext* executionContext = scriptState->executionContext();

- RefPtr<LocalFrame> protect = toDocument(executionContext)->frame();

+ RefPtrWillBeRawPtr<LocalFrame> protect(toDocument(executionContext)->frame());

ScriptDebugServer::compileScript(scriptState, expression, sourceURL, scriptId, exceptionDetailsText, lineNumber, columnNumber, stackTrace);

if (!scriptId->isNull())

m_compiledScriptURLs.set(*scriptId, sourceURL);

@@ -196,7 +196,7 @@ void PageScriptDebugServer::runScript(ScriptState* scriptState, const String& sc

if (frame)

cookie = InspectorInstrumentation::willEvaluateScript(frame, sourceURL, TextPosition::minimumPosition().m_line.oneBasedInt());

- RefPtr<LocalFrame> protect = frame;

+ RefPtrWillBeRawPtr<LocalFrame> protect(frame);

ScriptDebugServer::runScript(scriptState, scriptId, result, wasThrown, exceptionDetailsText, lineNumber, columnNumber, stackTrace);

if (frame)

« no previous file with comments | « LayoutTests/fast/events/message-port-gc-closed.html ('k') | Source/bindings/core/v8/ScriptController.cpp » ('j') | Source/core/editing/SpellChecker.h » ('J')