LayoutTests/fast/events/message-port-gc-closed.html - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/message-port-gc-closed.html

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/events/message-port-gc-closed.html

diff --git a/LayoutTests/fast/events/message-port-gc-closed.html b/LayoutTests/fast/events/message-port-gc-closed.html

index 4dba52da1a27ae633a9d72d6f1fc2a8b59fb1f41..0be397f62a154a78942ab169725bd02f38ad1935 100644

--- a/LayoutTests/fast/events/message-port-gc-closed.html

+++ b/LayoutTests/fast/events/message-port-gc-closed.html

@@ -2,14 +2,21 @@

<body>

-jsTestIsAsync = true;

description("MessagePorts (and their execution contexts) should be collected by GC once close() has been called on them");

+window.jsTestIsAsync = true;

window.onmessage = function(evt) {

iframeDocGC = internals.observeGC(document.querySelector('iframe').contentDocument);

document.querySelector('iframe').remove();

- gc();

- shouldBeTrue("iframeDocGC.wasCollected");

- finishJSTest();

+ // The iframe is reachable via evt.source, and evt is on the

+ // stack. asyncGC() will invoke the callback once back at

+ // the event loop (and after having forced a GC); evt

+ // will consequently no longer be in scope and the iframe

+ // will have been GCed.

+ asyncGC(function () {

+ shouldBeTrue("iframeDocGC.wasCollected");

+ finishJSTest();

+ });

}

</script>