Source/core/editing/TypingCommand.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TypingCommand.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comments + fix fast/events/message-port-gc-closed.html Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« LayoutTests/fast/events/message-port-gc-closed.html ('K') | « Source/core/editing/SpellChecker.cpp ('k') | Source/core/fetch/FetchContext.h » ('j') | Source/core/frame/DOMWindowProperty.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/TypingCommand.cpp

diff --git a/Source/core/editing/TypingCommand.cpp b/Source/core/editing/TypingCommand.cpp

index 47830a99e7d67baf690af586b3c3494656ccbd2b..72d5ebf42c192351416b9411e46f9eaffaf5eb6a 100644

--- a/Source/core/editing/TypingCommand.cpp

+++ b/Source/core/editing/TypingCommand.cpp

@@ -169,7 +169,7 @@ void TypingCommand::insertText(Document& document, const String& text, Options o

// FIXME: We shouldn't need to take selectionForInsertion. It should be identical to FrameSelection's current selection.

void TypingCommand::insertText(Document& document, const String& text, const VisibleSelection& selectionForInsertion, Options options, TextCompositionType compositionType)

{

- RefPtr<LocalFrame> frame = document.frame();

+ RefPtrWillBeRawPtr<LocalFrame> frame = document.frame();

ASSERT(frame);

VisibleSelection currentSelection = frame->selection().selection();