Source/core/frame/DOMWindowProperty.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMWindowProperty.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comments + fix fast/events/message-port-gc-closed.html Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/DOMWindowProperty.h

diff --git a/Source/core/frame/DOMWindowProperty.h b/Source/core/frame/DOMWindowProperty.h

index 2666f88c0fe13096ea5714ecf1f10fff7d89652a..a3d980f3774976f2262fa53e44fdb754db5738eb 100644

--- a/Source/core/frame/DOMWindowProperty.h

+++ b/Source/core/frame/DOMWindowProperty.h

@@ -49,10 +49,10 @@ protected:

virtual ~DOMWindowProperty();

#endif

- LocalFrame* m_frame;

+ RawPtrWillBeWeakMember<LocalFrame> m_frame;

RawPtrWillBeMember<LocalDOMWindow> m_associatedDOMWindow;

Mads Ager (chromium) 2014/09/16 12:17:44 It looks like the m_associatedDOMWindow is only ev

sof 2014/09/17 09:42:57 Quite right, it serves no purpose with Oilpan; gre

};

+} // namespace blink

#endif