Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 516963003: Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
Reviewers:
caseq, vsevik, dcheng, yurys, loislo
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, paulirish+reviews_chromium.org, vsevik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (patchset #3 of https://codereview.chromium.org/511873002/) Reason for revert: Creates timeout failures on a lot of inspector/ tests in Blink: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/33453/steps/webkit_tests/logs/stdio Original issue's description: > DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events > > Added IPC plumbing that allows InspectorTracingAgent to enable/disable browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol. > > BUG=398787 > > Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf TBR=dcheng@chromium.org,caseq@chromium.org,loislo@chromium.org,vsevik@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=398787 Committed: https://crrev.com/cbe4516d6cdfa0eef5cff4822190254fd51dac1f Cr-Commit-Position: refs/heads/master@{#292390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
M content/browser/devtools/devtools_protocol.h View 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_protocol.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.h View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 6 chunks +23 lines, -15 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M content/common/devtools_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-08-28 15:40:53 UTC) #1
Created Revert of DevTools: use explicit IPC messages for enabling/disabling
tracing instead of intercepting protocol…

Powered by Google App Engine
This is Rietveld 408576698