Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Side by Side Diff: content/browser/devtools/devtools_tracing_handler.h

Issue 516963003: Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_
6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 12 matching lines...) Expand all
23 // This class bridges DevTools remote debugging server with the trace 23 // This class bridges DevTools remote debugging server with the trace
24 // infrastructure. 24 // infrastructure.
25 class DevToolsTracingHandler : public DevToolsProtocol::Handler { 25 class DevToolsTracingHandler : public DevToolsProtocol::Handler {
26 public: 26 public:
27 enum Target { Browser, Renderer }; 27 enum Target { Browser, Renderer };
28 explicit DevToolsTracingHandler(Target target); 28 explicit DevToolsTracingHandler(Target target);
29 virtual ~DevToolsTracingHandler(); 29 virtual ~DevToolsTracingHandler();
30 30
31 void OnClientDetached(); 31 void OnClientDetached();
32 32
33 void EnableTracing(const std::string& category_filter);
34 void DisableTracing();
35
36 private: 33 private:
37 void BeginReadingRecordingResult(const base::FilePath& path); 34 void BeginReadingRecordingResult(const base::FilePath& path);
38 void ReadRecordingResult(const scoped_refptr<base::RefCountedString>& result); 35 void ReadRecordingResult(const scoped_refptr<base::RefCountedString>& result);
39 void OnTraceDataCollected(const std::string& trace_fragment); 36 void OnTraceDataCollected(const std::string& trace_fragment);
40 void OnRecordingEnabled(scoped_refptr<DevToolsProtocol::Command> command); 37 void OnRecordingEnabled(scoped_refptr<DevToolsProtocol::Command> command);
41 void OnBufferUsage(float usage); 38 void OnBufferUsage(float usage);
42 39
43 scoped_refptr<DevToolsProtocol::Response> OnStart( 40 scoped_refptr<DevToolsProtocol::Response> OnStart(
44 scoped_refptr<DevToolsProtocol::Command> command); 41 scoped_refptr<DevToolsProtocol::Command> command);
45 scoped_refptr<DevToolsProtocol::Response> OnEnd( 42 scoped_refptr<DevToolsProtocol::Response> OnEnd(
46 scoped_refptr<DevToolsProtocol::Command> command); 43 scoped_refptr<DevToolsProtocol::Command> command);
47 44
48 scoped_refptr<DevToolsProtocol::Response> OnGetCategories( 45 scoped_refptr<DevToolsProtocol::Response> OnGetCategories(
49 scoped_refptr<DevToolsProtocol::Command> command); 46 scoped_refptr<DevToolsProtocol::Command> command);
50 47
48 void OnTracingStarted(
49 scoped_refptr<DevToolsProtocol::Notification> notification);
50
51 void OnTracingStopped(
52 scoped_refptr<DevToolsProtocol::Notification> notification);
53
51 void OnCategoriesReceived(scoped_refptr<DevToolsProtocol::Command> command, 54 void OnCategoriesReceived(scoped_refptr<DevToolsProtocol::Command> command,
52 const std::set<std::string>& category_set); 55 const std::set<std::string>& category_set);
53 56
54 base::debug::TraceOptions TraceOptionsFromString(const std::string& options); 57 base::debug::TraceOptions TraceOptionsFromString(const std::string& options);
55 58
56 void SetupTimer(double usage_reporting_interval); 59 void SetupTimer(double usage_reporting_interval);
57 60
58 void DisableRecording( 61 void DisableRecording(
59 const TracingController::TracingFileResultCallback& callback = 62 const TracingController::TracingFileResultCallback& callback =
60 TracingController::TracingFileResultCallback()); 63 TracingController::TracingFileResultCallback());
61 64
62 base::WeakPtrFactory<DevToolsTracingHandler> weak_factory_; 65 base::WeakPtrFactory<DevToolsTracingHandler> weak_factory_;
63 scoped_ptr<base::Timer> buffer_usage_poll_timer_; 66 scoped_ptr<base::Timer> buffer_usage_poll_timer_;
64 Target target_; 67 Target target_;
65 bool is_recording_; 68 bool is_recording_;
66 69
67 static const char* kDefaultCategories; 70 static const char* kDefaultCategories;
68 static const double kDefaultReportingInterval; 71 static const double kDefaultReportingInterval;
69 static const double kMinimumReportingInterval; 72 static const double kMinimumReportingInterval;
70 73
71 DISALLOW_COPY_AND_ASSIGN(DevToolsTracingHandler); 74 DISALLOW_COPY_AND_ASSIGN(DevToolsTracingHandler);
72 }; 75 };
73 76
74 } // namespace content 77 } // namespace content
75 78
76 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_ 79 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_
OLDNEW
« no previous file with comments | « content/browser/devtools/devtools_protocol.cc ('k') | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698