Do not expose termination exceptions to the Exception API.

src/isolate.h

Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 11320d6f04a328037dd00acb7f75b5d485d80be5..eb647d10f8478d197bff159685b9cac0a1556f45 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -134,6 +134,17 @@ typedef ZoneList<Handle<Object> > ZoneObjectList;
 #define ASSIGN_RETURN_ON_EXCEPTION(isolate, dst, call, T)  \
   ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, MaybeHandle<T>())
 
+#define THROW_NEW_ERROR(isolate, call, T)                                      \
+  Handle<Object> __error__;                                                    \

[Toon Verwaest, 2014/09/01 08:20:26]

What about putting a scope around this?

+  ASSIGN_RETURN_ON_EXCEPTION(isolate, __error__, isolate->factory()->call, T); \
+  return isolate->Throw<T>(__error__);
+
+#define THROW_NEW_ERROR_RETURN_FAILURE(isolate, call)           \
+  Handle<Object> __error__;                                     \

[Toon Verwaest, 2014/09/01 08:20:25]

Same here

+  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, __error__,        \
+                                     isolate->factory()->call); \
+  return isolate->Throw(*__error__);
+
 #define RETURN_ON_EXCEPTION_VALUE(isolate, call, value)            \
   do {                                                             \
     if ((call).is_null()) {                                        \
@@ -762,7 +773,6 @@ class Isolate {
   // Return pending location if any or unfilled structure.
   MessageLocation GetMessageLocation();
   Object* ThrowIllegalOperation();
-  Object* ThrowInvalidStringLength();
 
   // Promote a scheduled exception to pending. Asserts has_scheduled_exception.
   Object* PromoteScheduledException();