Do not expose termination exceptions to the Exception API.

src/isolate.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_ISOLATE_H_
 #define V8_ISOLATE_H_
 
 #include "include/v8-debug.h"
 #include "src/allocation.h"
 #include "src/assert-scope.h"
@@ skipping 116 matching lines @@
     }                                                                \
   } while (false)
 
 #define ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, dst, call)  \
   ASSIGN_RETURN_ON_EXCEPTION_VALUE(                             \
       isolate, dst, call, isolate->heap()->exception())
 
 #define ASSIGN_RETURN_ON_EXCEPTION(isolate, dst, call, T)  \
   ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, MaybeHandle<T>())
 
+#define THROW_NEW_ERROR(isolate, call, T)                                      \
+  Handle<Object> __error__;                                                    \

[Toon Verwaest, 2014/09/01 08:20:26]

What about putting a scope around this?

+  ASSIGN_RETURN_ON_EXCEPTION(isolate, __error__, isolate->factory()->call, T); \
+  return isolate->Throw<T>(__error__);
+
+#define THROW_NEW_ERROR_RETURN_FAILURE(isolate, call)           \
+  Handle<Object> __error__;                                     \

[Toon Verwaest, 2014/09/01 08:20:25]

Same here

+  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, __error__,        \
+                                     isolate->factory()->call); \
+  return isolate->Throw(*__error__);
+
 #define RETURN_ON_EXCEPTION_VALUE(isolate, call, value)            \
   do {                                                             \
     if ((call).is_null()) {                                        \
       DCHECK((isolate)->has_pending_exception());                  \
       return value;                                                \
     }                                                              \
   } while (false)
 
 #define RETURN_FAILURE_ON_EXCEPTION(isolate, call)  \
   RETURN_ON_EXCEPTION_VALUE(isolate, call, isolate->heap()->exception())
@@ skipping 608 matching lines @@
   void ScheduleThrow(Object* exception);
   // Re-set pending message, script and positions reported to the TryCatch
   // back to the TLS for re-use when rethrowing.
   void RestorePendingMessageFromTryCatch(v8::TryCatch* handler);
   // Un-schedule an exception that was caught by a TryCatch handler.
   void CancelScheduledExceptionFromTryCatch(v8::TryCatch* handler);
   void ReportPendingMessages();
   // Return pending location if any or unfilled structure.
   MessageLocation GetMessageLocation();
   Object* ThrowIllegalOperation();
-  Object* ThrowInvalidStringLength();
 
   // Promote a scheduled exception to pending. Asserts has_scheduled_exception.
   Object* PromoteScheduledException();
   void DoThrow(Object* exception, MessageLocation* location);
   // Checks if exception should be reported and finds out if it's
   // caught externally.
   bool ShouldReportException(bool* can_be_caught_externally,
                              bool catchable_by_javascript);
 
   // Attempts to compute the current source location, storing the
@@ skipping 775 matching lines @@
   }
 
   EmbeddedVector<char, 128> filename_;
   FILE* file_;
   int scope_depth_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_ISOLATE_H_