Issue 516913003: Do not expose termination exceptions to the Exception API.

Issue 516913003: Do not expose termination exceptions to the Exception API. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Do not expose termination exceptions to the Exception API. R=verwaest@chromium.org BUG=403509 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=23544

Patch Set 2 : maybehandlified #

Patch Set 4 : address comment #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+466 lines, -472 lines)			Patch
M	src/accessors.cc	View	1	3 chunks	+29 lines, -10 lines	0 comments	Download
M	src/api.cc	View	1	1 chunk	+31 lines, -84 lines	0 comments	Download
M	src/builtins.cc	View	1	2 chunks	+9 lines, -8 lines	0 comments	Download
M	src/debug.cc	View	1	5 chunks	+18 lines, -14 lines	0 comments	Download
M	src/elements.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/execution.h	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/execution.cc	View	1	3 chunks	+35 lines, -33 lines	0 comments	Download
M	src/factory.h	View	1	1 chunk	+27 lines, -27 lines	0 comments	Download
M	src/factory.cc	View	1	11 chunks	+35 lines, -35 lines	0 comments	Download
M	src/ic/ic.cc	View	1	2 chunks	+5 lines, -9 lines	0 comments	Download
M	src/isolate.h	View	1 2 3	2 chunks	+16 lines, -1 line	0 comments	Download
M	src/isolate.cc	View	1 2 3	3 chunks	+10 lines, -14 lines	0 comments	Download
M	src/json-parser.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/json-stringifier.h	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/jsregexp.cc	View	1	3 chunks	+6 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	1	23 chunks	+77 lines, -82 lines	0 comments	Download
M	src/parser.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/runtime.cc	View	1	33 chunks	+124 lines, -122 lines	0 comments	Download
M	src/scopes.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	test/cctest/test-thread-termination.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm https://codereview.chromium.org/516913003/diff/40001/src/isolate.h File src/isolate.h (right): https://codereview.chromium.org/516913003/diff/40001/src/isolate.h#newcode138 src/isolate.h:138: Handle<Object> __error__; \ What about putting a scope ...

6 years, 3 months ago (2014-09-01 08:20:26 UTC) #2

Yang

6 years, 3 months ago (2014-09-01 09:12:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 23544 (presubmit successful).

Expand Messages | Collapse Messages