Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: content/browser/loader/resource_scheduler.cc

Issue 51683002: [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase onto 51953002 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | net/ocsp/nss_ocsp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_scheduler.cc
diff --git a/content/browser/loader/resource_scheduler.cc b/content/browser/loader/resource_scheduler.cc
index d458936ecf1e29110a8a935fbcbcca3ad155f5a6..3c735aea646f10a0ef173471a443eb3e478edd5c 100644
--- a/content/browser/loader/resource_scheduler.cc
+++ b/content/browser/loader/resource_scheduler.cc
@@ -290,7 +290,8 @@ void ResourceScheduler::ReprioritizeRequest(ScheduledResourceRequest* request,
}
client->pending_requests.Erase(request);
- client->pending_requests.Insert(request, request->url_request()->priority());
+ client->pending_requests.Insert(request,
akalin 2013/10/30 23:32:16 should this also do InsertAtFront if ignore_limits
akalin 2013/11/01 07:02:47 Matt, any opinion here? Should I add a TODO?
mmenke 2013/11/01 15:48:00 We shouldn't be reprioritizing those requests in t
akalin 2013/11/01 18:50:15 Ah, right. Added a check instead.
+ request->url_request()->priority());
if (new_priority > old_priority) {
// Check if this request is now able to load at its new priority.
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | net/ocsp/nss_ocsp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698