[Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY

content/browser/loader/resource_scheduler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/resource_scheduler.h"
 
 #include "base/stl_util.h"
 #include "content/common/resource_messages.h"
 #include "content/browser/loader/resource_message_delegate.h"
 #include "content/public/browser/resource_controller.h"
@@ skipping 272 matching lines @@
   }
 
   Client *client = client_it->second;
   if (!client->pending_requests.IsQueued(request)) {
     DCHECK(ContainsKey(client->in_flight_requests, request));
     // Request has already started.
     return;
   }
 
   client->pending_requests.Erase(request);
-  client->pending_requests.Insert(request, request->url_request()->priority());
+  client->pending_requests.Insert(request,

[akalin, 2013/10/30 23:32:16]

should this also do InsertAtFront if ignore_limits is set?

[akalin, 2013/11/01 07:02:47]

Matt, any opinion here? Should I add a TODO?

[mmenke, 2013/11/01 15:48:00]

We shouldn't be reprioritizing those requests in the first place.  Could make
this class more aware of those requests, but I don't think that's the way to go
about it.

[akalin, 2013/11/01 18:50:15]

Ah, right. Added a check instead.

+                                  request->url_request()->priority());
 
   if (new_priority > old_priority) {
     // Check if this request is now able to load at its new priority.
     LoadAnyStartablePendingRequests(client);
   }
 }
 
 void ResourceScheduler::LoadAnyStartablePendingRequests(Client* client) {
   while (!client->pending_requests.IsEmpty()) {
     ScheduledResourceRequest* request = client->pending_requests.FirstMax();
@@ skipping 81 matching lines @@
 
   return true;
 }
 
 ResourceScheduler::ClientId ResourceScheduler::MakeClientId(
     int child_id, int route_id) {
   return (static_cast<ResourceScheduler::ClientId>(child_id) << 32) | route_id;
 }
 
 }  // namespace content