content/child/service_worker/web_service_worker_provider_impl.h - Issue 516823003: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (2/4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.h

Issue 516823003: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (2/4) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate the reviews Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/service_worker/service_worker_dispatcher.cc ('K') | « content/child/service_worker/service_worker_dispatcher.cc ('k') | content/child/service_worker/web_service_worker_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_provider_impl.h

diff --git a/content/child/service_worker/web_service_worker_provider_impl.h b/content/child/service_worker/web_service_worker_provider_impl.h

index b78f4d0e8fb9539951a29bbd4f924781ac93a5f4..23726e4c8e437284be3499bf062988bbad382446 100644

--- a/content/child/service_worker/web_service_worker_provider_impl.h

+++ b/content/child/service_worker/web_service_worker_provider_impl.h

@@ -36,8 +36,9 @@ class WebServiceWorkerProviderImpl

const blink::WebURL& script_url,

WebServiceWorkerRegistrationCallbacks*);

- virtual void unregisterServiceWorker(const blink::WebURL& pattern,

- WebServiceWorkerRegistrationCallbacks*);

+ virtual void unregisterServiceWorker(

+ const blink::WebURL& pattern,

+ WebServiceWorkerUnregistrationCallbacks*);

nhiroki 2014/08/29 07:27:29 nit: Wrapped function arguments should have 4-spac

shimazu 2014/09/01 05:35:34 Done.

ServiceWorkerProviderContext* context() { return context_.get(); }