Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3128)

Unified Diff: Source/modules/filesystem/DOMFileSystemSync.cpp

Issue 516763002: Fix userVisibility for files in ChromeOS filesystems. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/filesystem/DOMFileSystemSync.cpp
diff --git a/Source/modules/filesystem/DOMFileSystemSync.cpp b/Source/modules/filesystem/DOMFileSystemSync.cpp
index b9c079600c04a29bc1a2755696cc1c2501445fb0..0ec12e7cc8afc2c7abacc85d1152fbcd0e2ef69e 100644
--- a/Source/modules/filesystem/DOMFileSystemSync.cpp
+++ b/Source/modules/filesystem/DOMFileSystemSync.cpp
@@ -124,20 +124,7 @@ public:
// *after* we've coined a File with a new handle that has the correct type set on it. This allows the
// blob storage system to track when a temp file can and can't be safely deleted.
- // For regular filesystem types (temporary or persistent), we should not cache file metadata as it could change File semantics.
- // For other filesystem types (which could be platform-specific ones), there's a chance that the files are on remote filesystem.
- // If the port has returned metadata just pass it to File constructor (so we may cache the metadata).
- // FIXME: We should use the snapshot metadata for all files.
- // https://www.w3.org/Bugs/Public/show_bug.cgi?id=17746
- if (m_type == FileSystemTypeTemporary || m_type == FileSystemTypePersistent) {
- m_result->m_file = File::createForFileSystemFile(metadata.platformPath, m_name);
- } else if (!metadata.platformPath.isEmpty()) {
- // If the platformPath in the returned metadata is given, we create a File object for the path.
- m_result->m_file = File::createForFileSystemFile(m_name, metadata).get();
- } else {
- // Otherwise create a File from the FileSystem URL.
- m_result->m_file = File::createForFileSystemFile(m_url, metadata).get();
- }
+ m_result->m_file = DOMFileSystemBase::createFile(metadata, m_url, m_type, m_name);
}
virtual bool shouldBlockUntilCompletion() const OVERRIDE
« no previous file with comments | « Source/modules/filesystem/DOMFileSystemBaseTest.cpp ('k') | Source/modules/filesystem/FileSystemCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698