Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3440)

Unified Diff: Source/modules/filesystem/DOMFileSystemBaseTest.cpp

Issue 516763002: Fix userVisibility for files in ChromeOS filesystems. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/filesystem/DOMFileSystemBase.cpp ('k') | Source/modules/filesystem/DOMFileSystemSync.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/filesystem/DOMFileSystemBaseTest.cpp
diff --git a/Source/modules/filesystem/DOMFileSystemBaseTest.cpp b/Source/modules/filesystem/DOMFileSystemBaseTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..a5c62f028607120855280255da5f5737a6a94ec5
--- /dev/null
+++ b/Source/modules/filesystem/DOMFileSystemBaseTest.cpp
@@ -0,0 +1,71 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/filesystem/DOMFileSystemBase.h"
+
+#include "core/fileapi/File.h"
+#include "public/platform/Platform.h"
+#include "public/platform/WebUnitTestSupport.h"
+#include <gtest/gtest.h>
+
+
+namespace blink {
+
+class DOMFileSystemBaseTest : public ::testing::Test {
+public:
+ DOMFileSystemBaseTest()
+ {
+ m_filePath = Platform::current()->unitTestSupport()->webKitRootDir();
+ m_filePath.append("/Source/modules/filesystem/DOMFileSystemBaseTest.cpp");
+ getFileMetadata(m_filePath, m_fileMetadata);
+ m_fileMetadata.platformPath = m_filePath;
+ }
+
+protected:
+ String m_filePath;
+ FileMetadata m_fileMetadata;
+};
+
+
+TEST_F(DOMFileSystemBaseTest, externalFilesystemFilesAreUserVisible)
+{
+ KURL rootUrl = DOMFileSystemBase::createFileSystemRootURL("http://chromium.org/", FileSystemTypeExternal);
+
+ RefPtrWillBeRawPtr<File> file = DOMFileSystemBase::createFile(m_fileMetadata, rootUrl, FileSystemTypeExternal, "DOMFileSystemBaseTest.cpp");
+ EXPECT_TRUE(file);
+ EXPECT_TRUE(file->hasBackingFile());
+ EXPECT_EQ(File::IsUserVisible, file->userVisibility());
+ EXPECT_EQ("DOMFileSystemBaseTest.cpp", file->name());
+ EXPECT_EQ(m_filePath, file->path());
+}
+
+TEST_F(DOMFileSystemBaseTest, temporaryFilesystemFilesAreNotUserVisible)
+{
+ KURL rootUrl = DOMFileSystemBase::createFileSystemRootURL("http://chromium.org/", FileSystemTypeTemporary);
+
+ RefPtrWillBeRawPtr<File> file = DOMFileSystemBase::createFile(m_fileMetadata, rootUrl, FileSystemTypeTemporary, "UserVisibleName.txt");
+ EXPECT_TRUE(file);
+ EXPECT_TRUE(file->hasBackingFile());
+ EXPECT_EQ(File::IsNotUserVisible, file->userVisibility());
+ EXPECT_EQ("UserVisibleName.txt", file->name());
+ EXPECT_EQ(m_filePath, file->path());
+}
+
+TEST_F(DOMFileSystemBaseTest, persistentFilesystemFilesAreNotUserVisible)
+{
+ KURL rootUrl = DOMFileSystemBase::createFileSystemRootURL("http://chromium.org/", FileSystemTypePersistent);
+
+ RefPtrWillBeRawPtr<File> file = DOMFileSystemBase::createFile(m_fileMetadata, rootUrl, FileSystemTypePersistent, "UserVisibleName.txt");
+ EXPECT_TRUE(file);
+ EXPECT_TRUE(file->hasBackingFile());
+ EXPECT_EQ(File::IsNotUserVisible, file->userVisibility());
+ EXPECT_EQ("UserVisibleName.txt", file->name());
+ EXPECT_EQ(m_filePath, file->path());
+}
+
+} // namespace blink
+
+
+
« no previous file with comments | « Source/modules/filesystem/DOMFileSystemBase.cpp ('k') | Source/modules/filesystem/DOMFileSystemSync.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698