Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 516713002: Don't send a QUIC SCUP message until after handshake confirmed. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@Change_TransmissionInfo_74076012
Project:
chromium
Visibility:
Public.

Description

Don't send a QUIC SCUP message until after handshake confirmed. A server config update was occasionally being sent before the crypto handshake was complete, causing the client to close the connection. Merge internal change: 74132773 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/quic/quic_crypto_server_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
6 years, 3 months ago (2014-08-28 00:51:51 UTC) #1
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-08-28 00:57:45 UTC) #2
wtc
wtc@chromium.org changed reviewers: + wtc@chromium.org
6 years, 3 months ago (2014-08-28 23:39:18 UTC) #3
wtc
6 years, 3 months ago (2014-08-28 23:39:18 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698