Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: net/quic/quic_crypto_server_stream_test.cc

Issue 516713002: Don't send a QUIC SCUP message until after handshake confirmed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Change_TransmissionInfo_74076012
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_crypto_server_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_server_stream_test.cc
diff --git a/net/quic/quic_crypto_server_stream_test.cc b/net/quic/quic_crypto_server_stream_test.cc
index 98492f19ebc26edfd941e80a4c6bde3037315e8f..7c529afc12264afe6ba14c552b188c7489ad9b5f 100644
--- a/net/quic/quic_crypto_server_stream_test.cc
+++ b/net/quic/quic_crypto_server_stream_test.cc
@@ -275,6 +275,12 @@ TEST_P(QuicCryptoServerStreamTest, ChannelIDAsync) {
EXPECT_TRUE(stream_.handshake_confirmed());
}
+TEST_P(QuicCryptoServerStreamTest, OnlySendSCUPAfterHandshakeComplete) {
+ // An attempt to send a SCUP before completing handshake should fail.
+ stream_.SendServerConfigUpdate(NULL);
+ EXPECT_EQ(0, stream_.num_server_config_update_messages_sent());
+}
+
} // namespace
} // namespace test
} // namespace net
« no previous file with comments | « net/quic/quic_crypto_server_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698