Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/gn/header_checker.h

Issue 516683002: Add GN variables for controlling header checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@desc
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/header_checker.h
diff --git a/tools/gn/header_checker.h b/tools/gn/header_checker.h
index c90c67a83277b669d00d41c3fdddf1ec13a1cdb4..2df2ca502a9ee2ba35d0a45c9537fc9c3fae4cae 100644
--- a/tools/gn/header_checker.h
+++ b/tools/gn/header_checker.h
@@ -39,7 +39,11 @@ class HeaderChecker : public base::RefCountedThreadSafe<HeaderChecker> {
// This assumes that the current thread already has a message loop. On
// error, fills the given vector with the errors and returns false. Returns
// true on success.
+ //
+ // force_check, if true, will override targets opting out of header checking
+ // with "check_includes = false" and will check them anyway.
bool Run(const std::vector<const Target*>& to_check,
+ bool force_check,
std::vector<Err>* errors);
private:
@@ -48,6 +52,7 @@ class HeaderChecker : public base::RefCountedThreadSafe<HeaderChecker> {
FRIEND_TEST_ALL_PREFIXES(HeaderCheckerTest,
IsDependencyOf_ForwardsDirectDependentConfigs);
FRIEND_TEST_ALL_PREFIXES(HeaderCheckerTest, CheckInclude);
+ FRIEND_TEST_ALL_PREFIXES(HeaderCheckerTest, CheckIncludeAllowCircular);
FRIEND_TEST_ALL_PREFIXES(HeaderCheckerTest,
GetDependentConfigChainProblemIndex);
~HeaderChecker();
@@ -65,7 +70,7 @@ class HeaderChecker : public base::RefCountedThreadSafe<HeaderChecker> {
// Backend for Run() that takes the list of files to check. The errors_ list
// will be populate on failure.
- void RunCheckOverFiles(const FileMap& flies);
+ void RunCheckOverFiles(const FileMap& flies, bool force_check);
void DoWork(const Target* target, const SourceFile& file);

Powered by Google App Engine
This is Rietveld 408576698