Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/functions_target.cc

Issue 516683002: Add GN variables for controlling header checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@desc
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/binary_target_generator.cc ('K') | « tools/gn/commands.h ('k') | tools/gn/header_checker.h » ('j') | tools/gn/value_extractors.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions_target.cc
diff --git a/tools/gn/functions_target.cc b/tools/gn/functions_target.cc
index 8aea0128ad85e2312765fc0d25d5d5103555a935..af548dca0430cb687a871d1603fac085f114cdde 100644
--- a/tools/gn/functions_target.cc
+++ b/tools/gn/functions_target.cc
@@ -292,6 +292,8 @@ Value RunComponent(Scope* scope,
TargetGenerator::GenerateTarget(&block_scope, function, args,
component_mode, err);
+ if (err->has_error())
+ return Value();
block_scope.CheckForUnusedVars(err);
return Value();
« tools/gn/binary_target_generator.cc ('K') | « tools/gn/commands.h ('k') | tools/gn/header_checker.h » ('j') | tools/gn/value_extractors.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698