Add GN variables for controlling header checking.

Add GN variables for controlling header checking.

BUG=
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/2f985cb

Committed: https://chromium.googlesource.com/chromium/src/+/26bbbb9

Committed: https://crrev.com/81db36ae08ef63897d0a5977509a7802e12ce45b
Cr-Commit-Position: refs/heads/master@{#292703}

[brettw, 2014-08-27 22:43:52]

brettw@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2014-08-27 23:30:40]

https://codereview.chromium.org/516683002/diff/20001/tools/gn/variables.cc
File tools/gn/variables.cc (right):

https://codereview.chromium.org/516683002/diff/20001/tools/gn/variables.cc#ne...
tools/gn/variables.cc:304: "  That is, if A depends on B, B can only include
headers from A if it is\n"
Does A have to depend on B? What if you put B in this list without A depending
on B (directly or indirectly)?

[brettw, 2014-08-28 05:46:16]

https://codereview.chromium.org/516683002/diff/20001/tools/gn/variables.cc
File tools/gn/variables.cc (right):

https://codereview.chromium.org/516683002/diff/20001/tools/gn/variables.cc#ne...
tools/gn/variables.cc:304: "  That is, if A depends on B, B can only include
headers from A if it is\n"
On 2014/08/27 23:30:40, viettrungluu wrote:
> Does A have to depend on B? What if you put B in this list without A depending
> on B (directly or indirectly)?

It must depend on B directly, there is code in the binary_target_generator that
enforces this.

[viettrungluu, 2014-08-28 19:47:54]

I still hate the name. <shrug>

https://codereview.chromium.org/516683002/diff/20001/tools/gn/binary_target_g...
File tools/gn/binary_target_generator.cc (right):

https://codereview.chromium.org/516683002/diff/20001/tools/gn/binary_target_g...
tools/gn/binary_target_generator.cc:109: // Validate that all circular includes
entriews are in the deps.
s/entriews/entries/

https://codereview.chromium.org/516683002/diff/20001/tools/gn/value_extractors.h
File tools/gn/value_extractors.h (right):

https://codereview.chromium.org/516683002/diff/20001/tools/gn/value_extractor...
tools/gn/value_extractors.h:49: // version taking Label*Ptrs, only the labels
are filled in, the ptr for each
s/Ptr/Pair/ ?

https://codereview.chromium.org/516683002/diff/20001/tools/gn/variables.cc
File tools/gn/variables.cc (right):

https://codereview.chromium.org/516683002/diff/20001/tools/gn/variables.cc#ne...
tools/gn/variables.cc:286: "allow_circular_includes_from: [label list] Permit
include cycles.";
"include cycles" is inaccurate and misleading.

https://codereview.chromium.org/516683002/diff/20001/tools/gn/variables.cc#ne...
tools/gn/variables.cc:288: "allow_circular_includes_from: Permit include cycles
from listed targets.\n"
"Permit includes from the listed targets, which are dependencies of this
target."?

[brettw, 2014-08-29 18:00:58]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-08-29 18:01:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/brettw@chromium.org/516683002/60001

[commit-bot: I haz the power, 2014-08-29 18:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 18:01:47]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brettw, 2014-08-29 19:04:20]

Didn't change the name, did do everything else. PTAL

[viettrungluu, 2014-08-29 19:17:51]

lgtm

[brettw, 2014-08-29 19:33:16]

The CQ bit was checked by brettw@chromium.org

[brettw, 2014-08-29 19:55:34]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2014-08-29 20:59:37]

Committed patchset #4 (id:60001) manually as 2f985cb (presubmit successful).

[brettw, 2014-08-29 22:25:46]

Committed patchset #4 (id:60001) manually as 26bbbb9 (presubmit successful).

[brettw, 2014-08-29 22:28:33]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-08-29 22:30:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/brettw@chromium.org/516683002/60001

[commit-bot: I haz the power, 2014-08-29 22:53:22]

Committed patchset #4 (id:60001) as c9a61bdbcfb706ac6d7138ab8d4f81347c9111a4

[commit-bot: I haz the power, 2014-09-10 03:11:16]

Patchset 4 (id:??) landed as
https://crrev.com/81db36ae08ef63897d0a5977509a7802e12ce45b
Cr-Commit-Position: refs/heads/master@{#292703}