Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/gn/commands.h

Issue 516683002: Add GN variables for controlling header checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@desc
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_check.cc ('k') | tools/gn/header_checker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/commands.h
diff --git a/tools/gn/commands.h b/tools/gn/commands.h
index a753af32dd192e28d11a282b837ba646720f3891..8603931d2bd50a8a03bd9ec71085137fec3acc24 100644
--- a/tools/gn/commands.h
+++ b/tools/gn/commands.h
@@ -99,11 +99,15 @@ bool ResolveTargetsFromCommandLinePattern(
// all_targets, and the specific targets to check should be in to_check. If
// to_check is empty, all targets will be checked.
//
+// force_check, if true, will override targets opting out of header checking
+// with "check_includes = false" and will check them anyway.
+//
// On success, returns true. If the check fails, the error(s) will be printed
// to stdout and false will be returned.
bool CheckPublicHeaders(const BuildSettings* build_settings,
const std::vector<const Target*>& all_targets,
- const std::vector<const Target*>& to_check);
+ const std::vector<const Target*>& to_check,
+ bool force_check);
} // namespace commands
« no previous file with comments | « tools/gn/command_check.cc ('k') | tools/gn/header_checker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698